Skip to content

Webhooks refactor#15

Merged
johnpmitsch merged 1 commit into
mainfrom
webhooks_refactor
Apr 27, 2026
Merged

Webhooks refactor#15
johnpmitsch merged 1 commit into
mainfrom
webhooks_refactor

Conversation

@johnpmitsch

@johnpmitsch johnpmitsch commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

Note

Medium Risk
Medium risk because it changes the wire serialization for webhook template operations and updates Node/Python binding surfaces and TypeScript typings, which could break existing consumers if shapes diverge from the API or prior SDK behavior.

Overview
Refactors webhook template handling so TemplateArgs is a serde-tagged enum ({ templateId, templateArgs }) that is #[serde(flatten)] into create_webhook_from_template / update_webhook_template requests, removing the prior “JSON-string value + manual body patching” approach.

Updates language bindings to match the new discriminated-union model: Node now accepts { templateId, args } and converts/case-normalizes it in a new webhooks_template wrapper, while Python replaces the exported TemplateArgs pyclass with per-template *Args wrapper classes and extraction logic at the FFI boundary.

Extends list_webhooks responses to include pageInfo via a new WebhookPageInfo type, and updates docs, tests, and e2e examples across Rust/Python/Node/Ruby accordingly.

Reviewed by Cursor Bugbot for commit 2ccb363. Bugbot is set up for automated code reviews on this repo. Configure here.

@johnpmitsch johnpmitsch merged commit dd9672f into main Apr 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant