Webhooks refactor#15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Medium risk because it changes the wire serialization for webhook template operations and updates Node/Python binding surfaces and TypeScript typings, which could break existing consumers if shapes diverge from the API or prior SDK behavior.
Overview
Refactors webhook template handling so
TemplateArgsis a serde-tagged enum ({ templateId, templateArgs }) that is#[serde(flatten)]intocreate_webhook_from_template/update_webhook_templaterequests, removing the prior “JSON-string value + manual body patching” approach.Updates language bindings to match the new discriminated-union model: Node now accepts
{ templateId, args }and converts/case-normalizes it in a newwebhooks_templatewrapper, while Python replaces the exportedTemplateArgspyclass with per-template*Argswrapper classes and extraction logic at the FFI boundary.Extends
list_webhooksresponses to includepageInfovia a newWebhookPageInfotype, and updates docs, tests, and e2e examples across Rust/Python/Node/Ruby accordingly.Reviewed by Cursor Bugbot for commit 2ccb363. Bugbot is set up for automated code reviews on this repo. Configure here.